Open eatmyvenom opened 3 months ago
Thank you for letting me know. Do you have an example map where I can see it in action and a link to a wiki so that I can recreate it locally? (I can't find any...)
my server is cacti.vnmm.dev if you wanna see an example
Thank you. Do I see it correctly, that the player waypoints render correctly with the current implementation because it shows the players in all maps for a dimension, but the marker waypoints just need to know all the map names / links to work correctly?
That's correct
In BlueMap, it is possible to have an infinite number of worlds for a singular dimension in game. A common example is one map for the Nether roof and the rest of the nether below a certain Y level. Both of these maps are taken from the same dimension but have different content and, specifically, different waypoints. Expected behavior would be that the client uses the waypoints from all the maps that match the client's current dimension rather than a single one.
Unfortunately this requires a bit more than a simple rewrite of
BlueMapConnection::getWaypointPositions
since this code needs to be reworked to be capable of working with multiple URLs vs the singular reqUrlhttps://github.com/thebuildcraft/RemotePlayerWaypointsForXaero/blob/7632930822bcaecb40b9b11a433e4f73e7c9f85b/common/src/main/java/de/the_build_craft/remote_player_waypoints_for_xaero/common/connections/BlueMapConnection.java#L103-L106
additionally the player logic would need changing since the current world would be actually multiple worlds in this case
https://github.com/thebuildcraft/RemotePlayerWaypointsForXaero/blob/7632930822bcaecb40b9b11a433e4f73e7c9f85b/common/src/main/java/de/the_build_craft/remote_player_waypoints_for_xaero/common/connections/BlueMapConnection.java#L162-L168