search

thecadams / 301RedirectModule

An improved version of the Sitecore 301 redirect module by Chris Castle, available at http://trac.sitecore.net/301RedirectModule
MIT License
30 stars 67 forks source link

Improve support of Sitecore 9.0 #41

Closed AlenPelin closed 6 years ago

AlenPelin commented 6 years ago

There are two key changes in this PR:

  1. Configuration roles annotations to config files to support Sitecore 9.0 natively in Scaled environments It is also compatible with Sitecore Configuration Roles
  2. Remove obsolete code in #if (SC82) ... #else region because #else ... #endif is compatible with both Sitecore 8.2 and Sitecore 9.0
thecadams commented 6 years ago

Hi and thanks for the contribution! Unfortunately due to Sitecore and Microsoft ecosystem being unfriendly to casual users, I haven't been able to get an environment up and running to validate the PR. Can you please get a code-review from someone in another GitHub organization? If you can, I'll be happy to merge.

Cheers! Chris

thecadams commented 6 years ago

Hi! Any luck with that code review?

AlenPelin commented 6 years ago

@romanchernyk @AndreyFilchenkov @olegburov @gravypower could you code review this PR, please?

thecadams commented 6 years ago

Heya @AlenPelin ! Let me know when it's reviewed and I'll be happy to merge.

gravypower commented 6 years ago

Looks good to me @AlenPelin.

RomanChernyk commented 6 years ago

Looks good. No comments.

thecadams commented 6 years ago

Thanks all.