thecartercenter / nemo

NEMO is a mobile data collection and analysis web application.
https://getnemo.org
Apache License 2.0
60 stars 63 forks source link

11469 uploader style #944

Closed plastichotsprings closed 1 year ago

plastichotsprings commented 1 year ago

Restyles the upload progress bar area (using flexboxes):

image

Wraps with flexbox for small screen sizes:

image

BONUS!: Added an aria-label to the delete icon where there previously was no descriptive text

Additional issue: It is not possible to TAB to the dropzone box to upload a file using keyboard navigation. Setting the tabindex of the dropzone box to 0 is not sufficient as the triggers are on click and on drag, not on keydown. To fix this we would need to listen for keydown.

plastichotsprings commented 1 year ago

nice improvements! and thanks for the screenshots.

changes look great other than a couple spec files that are now failing due to expected to find css ".dz-preview" but there were no matches, that should be a super easy fix.

Just attempted a fix of this, I ran the test myself and I'm getting errors related to Google APIs (see below). The css class name issue seems to be fixed though!

image

cooperka commented 1 year ago

spec failures are confirmed to only be "flappers" 👍 merging!