thecartercenter / nemo

NEMO is a mobile data collection and analysis web application.
https://getnemo.org
Apache License 2.0
60 stars 63 forks source link

12492: fix rendering to XML if there's a disabled cascading select questioning #960

Closed cooperka closed 10 months ago

cooperka commented 11 months ago

scenario:

result:

fix:

note that BOTH the if and else eventually attempt to use visible_children[0], but they only currently check if there are children and not whether the children are visible. this code logic is extremely complex and branching, but the fix here is likely safe.

tested and verified using the prod form linked from the redmine issue (screenshots not uploaded for privacy reasons).

jpdimond commented 10 months ago

Looks good to me kevin, thank you!