thecatcore / Fabric---Discord-Link

MIT License
75 stars 31 forks source link

Switch to Semantic Versioning #179

Closed psharma04 closed 2 years ago

psharma04 commented 2 years ago

Is your feature request related to a problem? Currently, Fabric attempts to check the versions of every mod. Since FDLink doesn't use Semantic Versioning, it dumps a whole list of warnings for the mod: [main/WARN]: Modfdlink(${version}) does not respect SemVer - comparison support is limited. [main/WARN]: Modfdlink_1_12_2(${version}) does not respect SemVer - comparison support is limited. [main/WARN]: Modfdlink_1_15_2(${version}) does not respect SemVer - comparison support is limited. [main/WARN]: Modfdlink_1_16(${version}) does not respect SemVer - comparison support is limited. [main/WARN]: Modfdlink_1_7_10(${version}) does not respect SemVer - comparison support is limited. [main/WARN]: Modfdlink_1_8_9(${version}) does not respect SemVer - comparison support is limited. [main/WARN]: Modfdlink_api(${version}) does not respect SemVer - comparison support is limited. [main/WARN]: Modfdlink_common(${version}) does not respect SemVer - comparison support is limited.

The suggestion Use semantic versioning in order to remove these warnings.

thecatcore commented 2 years ago

is this in dev environment or production?

thecatcore commented 2 years ago

oops, I think I broke it recently, will fix in the next 24h

thecatcore commented 2 years ago

Fixed in 0.10.4+ (when it releases)

psharma04 commented 2 years ago

This was in the production version from CurseForge.