thecatontheflat / atlassian-connect-bundle

Symfony Bundle for Atlassian Connect platform
MIT License
36 stars 19 forks source link

Refactor the JWTUserProvider and clean up code #39

Closed Matth-- closed 5 years ago

Matth-- commented 5 years ago
codecov-io commented 5 years ago

Codecov Report

Merging #39 into master will increase coverage by 8.89%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #39      +/-   ##
============================================
+ Coverage     35.16%   44.05%   +8.89%     
- Complexity      154      155       +1     
============================================
  Files            14       14              
  Lines           401      404       +3     
============================================
+ Hits            141      178      +37     
+ Misses          260      226      -34
Impacted Files Coverage Δ Complexity Δ
src/Security/JWTAuthenticator.php 100% <100%> (+26%) 27 <1> (+1) :arrow_up:
src/Security/JWTUserProvider.php 91.3% <100%> (+91.3%) 9 <3> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c38baa1...42382fb. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #39 into master will increase coverage by 8.89%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #39      +/-   ##
============================================
+ Coverage     35.16%   44.05%   +8.89%     
- Complexity      154      155       +1     
============================================
  Files            14       14              
  Lines           401      404       +3     
============================================
+ Hits            141      178      +37     
+ Misses          260      226      -34
Impacted Files Coverage Δ Complexity Δ
src/Security/JWTAuthenticator.php 100% <100%> (+26%) 27 <1> (+1) :arrow_up:
src/Security/JWTUserProvider.php 91.3% <100%> (+91.3%) 9 <3> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c38baa1...42382fb. Read the comment docs.

Bukashk0zzz commented 5 years ago

Good work. Thanks.