search

thecatontheflat / atlassian-connect-bundle

Symfony Bundle for Atlassian Connect platform
MIT License
36 stars 19 forks source link

Add custom authenticator for new Symfony authenticator #52

Closed Matth-- closed 3 years ago

Matth-- commented 3 years ago

Added functional tests for the new authenticator as well.

codecov-commenter commented 3 years ago

Codecov Report

Merging #52 (03c4fae) into master (430c6d8) will increase coverage by 3.94%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #52      +/-   ##
============================================
+ Coverage     58.57%   62.52%   +3.94%     
- Complexity      163      186      +23     
============================================
  Files            14       16       +2     
  Lines           408      451      +43     
============================================
+ Hits            239      282      +43     
  Misses          169      169
Impacted Files Coverage Δ
.../DependencyInjection/AtlassianConnectExtension.php 100.00% <100.00%> (ø)
src/Entity/TenantTrait.php 54.83% <100.00%> (+0.99%) :arrow_up:
src/Security/JWTAuthenticator.php 100.00% <100.00%> (ø)
src/Security/JWTSecurityHelper.php 100.00% <100.00%> (ø)
src/Security/LegacyJWTAuthenticator.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 430c6d8...03c4fae. Read the comment docs.

Matth-- commented 3 years ago

@Bukashk0zzz @thecatontheflat

👋 . Would it be possible to review the PR? If you want any help maintaining the library, I would be interested in doing so!

Bukashk0zzz commented 3 years ago

Thanks. The super huge work done here. I checked your request briefly. And look like you know how to write code ;) so I just checked for logic about new/legacy Auth classes all look good. And adding functional tests with actual configs was a super good idea.

I don't have rights to make you a maintainer. This can only be done by @thecatontheflat

thecatontheflat commented 3 years ago

Thanks for offering help @Matth-- ! I've sent you the invite!