thechangelog / changelog.com

Changelog is news and podcast for developers. This is our open source platform.
https://changelog.com/posts/changelog-is-open-source
Other
2.71k stars 245 forks source link

Rotate all the secrets #442

Closed gerhard closed 1 year ago

gerhard commented 1 year ago

We used to keep our app secrets in LastPass. While we have migrated to 1Password part of https://github.com/thechangelog/changelog.com/discussions/433, in light of Hackers stole encrypted LastPass password vaults, and we’re just now hearing about it, the only way to know for sure that our secrets are secure, we must rotate all credentials that we used to store in LastPass.

We will take this opportunity to see which services are no longer in use, and DELETE them.

Used by changelog-2022-03-13 app

ENVs in 1Password

gerhard commented 1 year ago

Follow-ups:

jerodsanto commented 1 year ago

@gerhard pretty close to done! I believe the Sentry auth token was set up by you and I couldn't find it anywhere from my account. It's only called from the sentry-release command in the Makefile. Can you handle this one?

gerhard commented 1 year ago

Yes, I set up that integration: https://changelog-media.sentry.io/settings/developer-settings/

Screenshot 2023-02-18 at 08 20 59

BUT I no longer have the necessary permissions to create a new integration.

Can you assign me Manager permissions? Knowing how I roll, I would prefer Owner so that I don't hit any limitations in the future. Only @adamstac can do this according to https://changelog-media.sentry.io/settings/members/

jerodsanto commented 1 year ago

You are now a Manager

gerhard commented 1 year ago

I have set up a new integration before realizing that I could have added a new token to the existing one. When you have a moment @adamstac, can you please delete sentry-release-on-app-start-2023-02-18 (requires Owner privileges).

Actually, you can also delete sentry-release-on-app-start. FWIW https://github.com/thechangelog/changelog.com/commit/61f1dda8f521f2c7410b010cf628611c6741ffe0

gerhard commented 1 year ago

I think that we can close this even though the SLACK_DEPLOY_WEBHOOK has not been rotated. It's OK to re-open if you think otherwise.

FTR: https://api.slack.com/apps/AJLKS2NAV/incoming-webhooks & https://github.com/thechangelog/changelog.com/pull/418

image