search

thecharlieblake / Solvitaire

A solver for a range of perfect-information, single player solitaire card games
GNU General Public License v2.0
32 stars 11 forks source link

Fix GitHub license detection #128

Closed shlomif closed 4 years ago

shlomif commented 4 years ago

So it will say GPL-2.0 and more people will want to take a look.

thecharlieblake commented 4 years ago

Hi Shlomi, happy to make this change - but can you tell me what the effect is? There is some automatic license detection which github isn't doing because of the filename copyright.txt? Where can one see the license detection?

shlomif commented 4 years ago

Hi @thecharlieblake !

Hi Shlomi, happy to make this change - but can you tell me what the effect is? There is some automatic license detection which github isn't doing because of the filename copyright.txt? Where can one see the license detection?

See https://github.com/licensee/licensee (try the --no-remote flag). Basically, it allows GitHub/etc. to recognise the licence of the repo. See e.g https://github.com/search?utf8=%E2%9C%93&q=freecell%20solver where it says "MIT License" next to "fc-solve".

thecharlieblake commented 4 years ago

Ah I see - thanks for doing this. Hopefully will increase visibility!

shlomif commented 4 years ago

@thecharlieblake : hi! As a postscript to this pullreq see https://github.com/licensee/licensee/issues/466 . There is still some distance to go.

thecharlieblake commented 4 years ago

I saw that it didn't update when I merged but just assumed it would take some time for GitHub to update/crawl the repo. That may still be the case ofc. Will keep an eye on this, thanks!

shlomif commented 4 years ago

I saw that it didn't update when I merged but just assumed it would take some time for GitHub to update/crawl the repo. That may still be the case ofc. Will keep an eye on this, thanks!

An update: the Licence has been detected now: https://github.com/thecharlieblake/Solvitaire ; it is still not displayed in this search however: https://github.com/search?utf8=%E2%9C%93&q=solvitaire .

thecharlieblake commented 4 years ago

That's good news! Hopefully it's just a timings issue then. Thanks for letting me know.

Charlie

On Sat, 24 Oct 2020, 08:35 Shlomi Fish, notifications@github.com wrote:

I saw that it didn't update when I merged but just assumed it would take some time for GitHub to update/crawl the repo. That may still be the case ofc. Will keep an eye on this, thanks!

An update: the Licence has been detected now: https://github.com/thecharlieblake/Solvitaire ; it is still not displayed in this search however: https://github.com/search?utf8=%E2%9C%93&q=solvitaire .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/thecharlieblake/Solvitaire/pull/128#issuecomment-715866955, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEEM7W6LEHEQKGYFLULQOCDSMJ7VLANCNFSM4SXUYQBA .

thecharlieblake commented 4 years ago

@shlomif success! https://github.com/search?utf8=%E2%9C%93&q=solvitaire now shows the license properly. Thanks for doing this.

shlomif commented 4 years ago

@shlomif success! https://github.com/search?utf8=%E2%9C%93&q=solvitaire now shows the license properly. Thanks for doing this.

You're welcome! I received an email reply to my GitHub support ticket which said that it had been a reindexing problem and that they manually reindexed the Solvitaire's repository's record to fix it for us.