thechinkysight / paginable

A Flutter package which makes pagination easier.
https://pub.dev/packages/paginable
BSD 3-Clause "New" or "Revised" License
7 stars 1 forks source link

enhancement: let scroll notifications bubble #12

Closed harkairt closed 2 years ago

harkairt commented 2 years ago

Currently the onNotification callback returns true, making ancestor unable to tap into scroll events.

        onNotification: (ScrollUpdateNotification scrollUpdateNotification) {
          if (isAlmostAtTheEndOfTheScroll(scrollUpdateNotification) &&
              isScrollingDownwards(scrollUpdateNotification)) {
            if (!isLoadMoreBeingCalled) {
              performPagination();
            }
          }
          return true;
        },

I have a widget which conditionally elevates the AppBar when the content is scrolled. But it does not work with PaginableListViewBuilder.

~Sorry for not making a PR.~ I made one but could not push branch :D Thanks for the package!

harkairt commented 2 years ago

thanks :)