thechiselgroup / biomixer

BioMixer
http://bio-mixer.appspot.com/
16 stars 13 forks source link

Filter by Edge Types, Ontologies, Individual Nodes #369

Closed everbeek closed 10 years ago

everbeek commented 10 years ago

We definitely want a filter to show only concept, mapping, or composition edge types. Populate off of a container of edge types. Some expansions create an amazing amount of relations, so we need to cull to be able to read what is added.

everbeek commented 10 years ago

Have it working for individual nodes. This is not the most useful thing, but it makes the other ones easy to achieve. I can always remove the UI elements that correspond to this.

On to ontology filtering!

everbeek commented 10 years ago

Have ontology and cherry pick filters refactored to use the same code. Totally awesome. I still need to sort out the checkbox behavior when ontology and cherry picked selections overlap. The graph behaves fine, but the checkboxes get into invalid states. I also need to get rid of empty functions in the base FilterWidget class.

everbeek commented 10 years ago

Fixed empty methods in FilterWidget with implementation-of-interface injection. Have cherry picker and ontology checkboxes working for both hover over and activation. Tweaked UI for the menu a bit, made it transparent.

Now I need to work on edge type filtering, and also find out when and how a space got added above the menu trigger.

everbeek commented 10 years ago

Have the menus cleaned up, and have all three of link, ontology, and concept checkbox filters.

everbeek commented 10 years ago

Talked with Peggy and I should indeed make the checkboxes consistent with state. We weren't able to think of a simple way to allow precedence of filters, but we did agree that the checkboxes need to reflect the filtered state properly. Checking the ontology should check/uncheck all individual checkboxes, and changing individual ones should grey out the ontology checkboxes (indicating mixed state).

everbeek commented 10 years ago

Have the checkbox state inter-relations working well.

I noticed that edges are being left in when I have an ontology filtered out, but nodes brought back in individually. Oh, fixed it. The check for arc hiding was looking at rects rather than svg:g elements, which are the ones that actually carry hidden status.

Also, I thought there used to be hover-over for the checkboxes, but it isn't working right now. Fixing that next.