search

thechiselgroup / biomixer

BioMixer
http://bio-mixer.appspot.com/
16 stars 13 forks source link

FetchFromApi has Dead Code #407

Closed everbeek closed 10 years ago

everbeek commented 10 years ago

See FetchFromApi, method updateStatusForUrlInRestCallRegistry(), where the currentStatus is initialized as undefined, then compared against that immediately.

Was this somehow on purpose? If not, figure out whether it needs fixing or if it needs deleting.

everbeek commented 10 years ago

Code around this was refactored, and I missed replacing the initialization with a setting. Fixing, but I doubt we'll see a difference easily, since the path into fetching is deep and prevents redundancy fairly well. It keeps the intended logic applied though.