search

thechiselgroup / biomixer

BioMixer
http://bio-mixer.appspot.com/
16 stars 13 forks source link

Undo of Expansion Leaves Phantom Nodes in Tree Layout #425

Closed everbeek closed 9 years ago

everbeek commented 9 years ago

When I expand a node, then trigger the tree layout, undoing the expansion makes it so that the remaining tree only takes up as much space as it already has. I think this is a side effect of using phantom nodes. They likely need to be removed and reconstructed on undo and redo.

This won't be visible except in master, which has the issue330_d3layout branch merged in (as of today's commit for that branch).

everbeek commented 9 years ago

I recall that Elena said she fixed this, and also, I made redo/undo take a layout snapshot to be applied when the undo or redo is applied, so I wouldn't be able to see this now. It looks fixed...deleting the expansion set that I was testing didn't appear to leave any phantom node around, since retriggering the tree layout led to exactly what I saw prior to the expansion.