thechiselgroup / biomixer

BioMixer
http://bio-mixer.appspot.com/
16 stars 13 forks source link

Import Cascades to Expansions #460

Closed everbeek closed 9 years ago

everbeek commented 9 years ago

Import from: http://internal-demo-2.bio-mixer-hrd.appspot.com/conceptPathToRoot.html?gwt.codesvr=127.0.0.1:9997&initial_vis=paths_to_root&ontology_acronym=SNOMEDCT&full_concept_id=http%3A%2F%2Fpurl.bioontology.org%2Fontology%2FSNOMEDCT%2F35146001

To: http://internal-demo-2.bio-mixer-hrd.appspot.com/conceptPathToRoot.html?gwt.codesvr=127.0.0.1:9997&initial_vis=term_neighborhood&ontology_acronym=UBERON&full_concept_id=http://purl.obolibrary.org/obo/UBERON_0002407&restURLPrefix=data.bioontology.org

In Chrome, this leads to many many (300?) nodes being loaded. In Firefox, it overloads the browser.

I think the term neighbourhood expansion type is cascading down to let all the imported nodes fetch their term neighbourhoods. That is not what I wanted. Fix it, test in Firefox to make sure as well, since Cassie found it there.

everbeek commented 9 years ago

Fixed it by checking for null for expansion type and parent of expansion. Normally, those don't happen, but they do in import.

As a side note, it takes about 8 seconds to load the arcs for this import. I know that I need to go through all the relation fetching calls anyway, for great justice, but if there are complaints about the time to import, I can consider exporting extant edges as well (and leave all the non-visible ones for the regular relation discovery flow). That would bring loading down to about...1 second, but it would expand the import JSON by a factor of approximately 2 for tree structures with no additional mappings, and by a larger number for importation of near-cliques. So, ya, I won't do that now, it doesn't seem worth it at the moment.