thechiselgroup / biomixer

BioMixer
http://bio-mixer.appspot.com/
16 stars 13 forks source link

Embed Viz Height Problem #492

Closed everbeek closed 9 years ago

everbeek commented 9 years ago

In the embed, the viz uses significantly more than the available height of the visualization.

$("#biomixer_iframe").attr("src", $("#biomixer_iframe").attr("src").replace("http://bioportal-integration.bio-mixer.appspot.com/", "http://bioportal-integration-test.bio-mixer.appspot.com/"));

everbeek commented 9 years ago

This occurs because the container above the iframe is set to a height of 900px, but the height of the overall container is less than that. This means it is a BioPortal bug, but I can make BioMixer more robust.

I will try to detect if a scrollbar is present, and reduce the graph area prior to loading nodes. I will have to test this with window resizing as well.

everbeek commented 9 years ago

I don't think I can fix this in an acceptable way from my end. The outer Bioportal container should probably expand to accommodate the space they have allocated for the visualization. I would try further to make the viz more robust to size problems like this, but I am having trouble figuring out the incantation to find the actual visible size of the panel. it seems that when the viz is first created, it works, but then something happens, such as the container expanding to 900px, and my size values reflect that...the alternative size inspection I am trying is clearly not working.

everbeek commented 9 years ago

Dupe of #530. This is what happens when fairly important problems don't get fixed: they reproduce to multiple issues.