thechunter / nh-stats-docker

nh-stats docker container
Apache License 2.0
5 stars 0 forks source link

Occasional spike in profits #2

Open thechunter opened 6 years ago

thechunter commented 6 years ago

This user is reporting an anomalous spike in profits when the NiceHash wallet pays out. I must have missed something in the wrapping logic.

thechunter commented 6 years ago

I have a fix mostly in place. Moving the timestamp up to the top of the script made things way more robust, but I think the next release really needs to parse the timestamp returned by the NiceHash API rather than the system time at the time I request the data from NiceHash.

thechunter commented 6 years ago

I was wrong -- there isn't a timestamp within the return from the NiceHash API. I saw some time fields, but those were for previous payments. The current solution of getting system time at the opt of the script will have to be good enough.

thechunter commented 6 years ago

This still isn't fixed. I noticed it in version 1.1 that is running on my server. But, I don't think this has anything to do with wrapping around payouts.

screen shot 2018-07-11 at 8 36 54 am

At 4:21 nh-stats explicitly entered 0-valued balances for every algorithm. I'm currently unsure why this happened. I need to investigate some better try-catch around the NH API in case it returned an error. If we don't grab valid balances, we should just skip the datapoint.

thechunter commented 6 years ago

I've deployed a new development image (tag 1.2 on nh-stats-dev) for testing this fix.

TheChrisTech commented 6 years ago

I got paid last night while running 1.2 and can confirm that there was no spike as I previously saw.

2018-07-12 20_09_40-
thechunter commented 6 years ago

GitHawk Upload by thechunter

Sent with GitHawk

thechunter commented 6 years ago

It’s back

Sent with GitHawk