thechutrain / rc-coffee-chats

A service that matches community members for chats
MIT License
15 stars 7 forks source link

Python2 likely no longer needed #98

Open amedeedaboville opened 4 years ago

amedeedaboville commented 4 years ago

Description

The README mentions that python2 is required because of the better-sqlite3 package. It itself requires python2 because it depends on node-gyp, but recent versions of node-gyp support python3 and don't require python2.

The user may need to do npm i -g node-gyp@latest (see https://github.com/JoshuaWise/better-sqlite3/issues/345) And we may need to update better-sqlite3 to version 6.0.1. (https://github.com/JoshuaWise/better-sqlite3/issues/310#issuecomment-590351849)

Reading the commit log (they don't seem to have a changelog?) It doesn't look like anything has broken between better-sqlite3 version 5.4.0 as is currently in package.json vs 6.0.1. I will run the tests with 6.0.1, and maybe will try installing this in a docker?

Expected result

Python2 should no longer be required to install rc-coffee-chats.

Actual result

Python2 is still required to to install rc-coffee-chats