search

theckman / yacspin

Yet Another CLi Spinner; providing over 80 easy to use and customizable terminal spinners for multiple OSes
Apache License 2.0
434 stars 13 forks source link

Separate updates to content from spinner animation #17

Closed theckman closed 4 years ago

theckman commented 4 years ago

Prior to this, your spinner content could only be updated as often as the spinner was rendering. Data liveliness was tied to your animation speed, which meant for faster updates you had to sacrifice what your spinner animation looked like.

This change separates the two, so that calling a method like Message() should update the spinner's message in near realtime without the spinner itself being animated.

codecov[bot] commented 4 years ago

Codecov Report

Merging #17 into master will increase coverage by 0.35%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   91.58%   91.94%   +0.35%     
==========================================
  Files           2        2              
  Lines         309      335      +26     
==========================================
+ Hits          283      308      +25     
- Misses         13       14       +1     
  Partials       13       13
Impacted Files Coverage Δ
spinner.go 91.64% <100.00%> (+0.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e3e8fd...3b9cb0f. Read the comment docs.