search

theckman / yacspin

Yet Another CLi Spinner; providing over 80 easy to use and customizable terminal spinners for multiple OSes
Apache License 2.0
438 stars 13 forks source link

Reduce number operations we do inside of the mutex #20

Closed theckman closed 4 years ago

theckman commented 4 years ago

Some of the things we were doing inside of the mutex weren't protected by the mutex itself. This reshuffles the code a bit to consider that and do as little inside of the mutex as we can.

codecov[bot] commented 4 years ago

Codecov Report

Merging #20 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #20      +/-   ##
=========================================
+ Coverage   92.48%   92.5%   +0.01%     
=========================================
  Files           2       2              
  Lines         386     387       +1     
=========================================
+ Hits          357     358       +1     
  Misses         15      15              
  Partials       14      14
Impacted Files Coverage Δ
spinner.go 92.26% <100%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a588121...5606b78. Read the comment docs.