search

theckman / yacspin

Yet Another CLi Spinner; providing over 80 easy to use and customizable terminal spinners for multiple OSes
Apache License 2.0
434 stars 13 forks source link

feat: ✨ Add WriteFn as alternative to io.Writer #30

Closed ghostsquad closed 4 years ago

ghostsquad commented 4 years ago

This adds support other applications that need an explicit string on update, an no erasure characters.

resolves #28

ghostsquad commented 4 years ago

This should also resolve https://github.com/rivo/tview/issues/462

codecov[bot] commented 4 years ago

Codecov Report

Merging #30 into master will decrease coverage by 0.72%. The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   92.65%   91.93%   -0.73%     
==========================================
  Files           2        2              
  Lines         395      409      +14     
==========================================
+ Hits          366      376      +10     
- Misses         15       17       +2     
- Partials       14       16       +2
Impacted Files Coverage Δ
spinner.go 91.68% <76.47%> (-0.75%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2091764...562f030. Read the comment docs.

ghostsquad commented 4 years ago

I apologize, but I cannot keep the code coverage from decreasing any more than what it's at (-0.73%). It seems that some of the lines (panics) are currently not covered, and covering them as part of this PR is out of scope. Let me know if the tests I wrote are sufficient.

theckman commented 4 years ago

Let's work through documenting the problem we're solving in the related issue, and once that's clear we can review the implementation.