search

theckman / yacspin

Yet Another CLi Spinner; providing over 80 easy to use and customizable terminal spinners for multiple OSes
Apache License 2.0
434 stars 13 forks source link

Use colorable to support Windows terminals; remove vendor/ directory #39

Closed theckman closed 2 years ago

theckman commented 2 years ago

This change adds a direct dependency on github.com/mattn/go-colorable to support Windows terminals, and removes the plumbing that hardcodes Windows as a dumb terminal. This is inspired by #32 opened by @OtisOat.

This also removes the vendor/ directory, as it's even less valuable with our usage of Modules.

Closes #32

codecov[bot] commented 2 years ago

Codecov Report

Merging #39 (e5c32e2) into master (d44d3a2) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files           2        2           
  Lines         529      529           
=======================================
  Hits          500      500           
  Misses         15       15           
  Partials       14       14
Flag Coverage Δ
unittests 94.51% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
spinner.go 94.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d44d3a2...e5c32e2. Read the comment docs.