theckman / yacspin

Yet Another CLi Spinner; providing over 80 easy to use and customizable terminal spinners for multiple OSes
Apache License 2.0
434 stars 13 forks source link

Add Start() tests, make safer for concurrent access #7

Closed theckman closed 4 years ago

theckman commented 4 years ago

This adds test coverage for .Start() method, and also makes some of the methods safe for concurrent use and/or that they correctly set the maxwidth.

codecov[bot] commented 4 years ago

Codecov Report

Merging #7 into master will increase coverage by 14.14%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #7       +/-   ##
===========================================
+ Coverage   56.05%   70.19%   +14.14%     
===========================================
  Files           2        2               
  Lines         289      302       +13     
===========================================
+ Hits          162      212       +50     
+ Misses        121       84       -37     
  Partials        6        6               
Impacted Files Coverage Δ
spinner.go 68.96% <100.00%> (+14.81%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b601287...5060e87. Read the comment docs.