search

thecodecrate / city-state

Simple ruby gem to create form lists with cities and states
MIT License
306 stars 135 forks source link

Invalid data for GB #34

Open lucabob opened 6 years ago

lucabob commented 6 years ago

This gem returns completely invalid data for GB:

irb(main):001:0> CS.get(:gb)
{:ENG=>"England",
 :KEN=>"Kent",
 :LND=>"City of London",
 :NIR=>"Northern Ireland",
 :SCT=>"Scotland",
 :SOM=>"Somerset",
 :SRY=>"Surrey",
 :WLS=>"Wales"}

It returns a mixture of counties, local government, countries and provinces. It should probably refer to ISO 3166-2:GB, and return the codes for what that considers countries and provinces.

hemaldev commented 6 years ago

Have just come across this gem, shame it doesn't seem to be maintained. I ran CS.update and CS.get(:gb) and got

{:ENG=>"England", :NIR=>"Northern Ireland", :SCT=>"Scotland", :WLS=>"Wales"}

Perhaps CS.update did the trick...