search

thecodecrate / city-state

Simple ruby gem to create form lists with cities and states
MIT License
306 stars 135 forks source link

update: updated country.yml with latest #49

Closed devkumarvdb closed 2 years ago

devkumarvdb commented 3 years ago

Heroku Update fix.

Updated countries.yml because we cannot perform on update.

inderps commented 2 years ago

@devkumarvdb Can you please update "Republic of Lithuania" to "Lithuania" as well?

inderps commented 2 years ago

@loureirorg is this ever going to be merged?

devkumarvdb commented 2 years ago

@devkumarvdb Can you please update "Republic of Lithuania" to "Lithuania" as well?

Sure I will check on it.

loureirorg commented 2 years ago

@inderps I understand it can be frustrating to have a country name in a different way than is expected or known.

But as this library is just a wrapper to the MaxMind database, anything written to country.yml file is gonna be lost on an update.

If you want to fix a name, the best way is to use db/countries-lookup.yml:

# db/countries-lookup.yml
LT: "Lithuania"
loureirorg commented 2 years ago

@devkumarvdb Thanks for spending some time updating the countries list.

I will merge your PR but be aware that I have plans to create a GitHub action to automatically update this file from time to time using CS.update command. This means any change that is not in sync with MaxMind will be lost.

devkumarvdb commented 2 years ago

@loureirorg No worries the update was done using CS.update only.