search

thecodecrate / city-state

Simple ruby gem to create form lists with cities and states
MIT License
306 stars 135 forks source link

Amend dependency #56

Closed emancu closed 1 year ago

emancu commented 1 year ago

While running bundle install I can see the following message

RubyZip 3.0 is coming!
**********************

The public API of some Rubyzip classes has been modernized to use named
parameters for optional arguments. Please check your usage of the
following classes:
  * `Zip::File`
  * `Zip::Entry`
  * `Zip::InputStream`
  * `Zip::OutputStream`

Please ensure that your Gemfiles and .gemspecs are suitably restrictive
to avoid an unexpected breakage when 3.0 is released (e.g. ~> 2.3.0).
See https://github.com/rubyzip/rubyzip for details. The Changelog also
lists other enhancements and bugfixes that have been implemented since
version 2.3.0.

I think it is nice to prevent a problem, until it is tested with version 3.0

emancu commented 1 year ago

@loureirorg has been fixed?

loureirorg commented 1 year ago

Hi, @emancu

Firstly, I want to apologize for having your PR closed in an unexpected way. I recently made the decision to rename the main branch to main, and I wasn't aware that this action would close all the PRs that were made to the old master branch.

To provide a bit of context: I had taken a hiatus from maintaining this gem for several years due to personal and professional commitments. However, I've recently resumed my efforts to improve and update this project.

I appreciate the time and effort you took to make this PR. Limiting the version of the RubyZip dependency is important to avoid possible problems for the users of this gem in the future when RubyZip 3 is officially released.

I'm in the process of reviewing all PRs and issues and I will be addressing them as quickly as I can. I'll also be implementing measures to ensure better communication and responsiveness moving forward.

For your PR, I'll review it and manually apply your changes and credit you for your contribution. If you have any other insights, suggestions, or feedback, I'd love to hear them.

Thank you for your contribution to the gem.