thecodeholic / lobipanel

jQuery plugin for bootstrap panels. It extends panels with several common and useful functions.
MIT License
168 stars 75 forks source link

Saved state issue #33

Open metalmini opened 7 years ago

metalmini commented 7 years ago

Hi,

First of all, great plugin. Works like a charm and looks nice.

I have one problem which i cannot seem to get fixed. I use the bootstrap grid to split the screen in half and display an amount of panels in there, like so:

<div class="row">
    <div class="col-md-6 lobipanel-parent-sortable ui-sortable" data-lobipanel-child-inner-id="lobipanel-data-attributes-2 lobipanel-data-attributes-3 lobipanel-data-attributes-4 lobipanel-data-attributes-5 lobipanel-data-attributes-6 lobipanel-data-attributes-7">
        <div class="panel panel-default lobipanel lobipanel-sortable" data-inner-id="lobipanel-data-attributes-3" data-index="NaN" style="display: block;"></div>
        <div class="panel panel-default lobipanel lobipanel-sortable" data-inner-id="lobipanel-data-attributes-5" data-index="1" style="display: block;"></div>
        <div class="panel panel-default lobipanel lobipanel-sortable" data-inner-id="lobipanel-data-attributes-2" data-index="NaN" style="display: block;"></div>
        <div class="panel panel-default lobipanel lobipanel-sortable" data-inner-id="lobipanel-data-attributes-4" data-index="NaN" style="display: block;"></div>
        <div class="panel panel-default lobipanel lobipanel-sortable" data-inner-id="lobipanel-data-attributes-6" data-index="5" style="display: block;"></div>
        <div class="panel panel-default lobipanel lobipanel-sortable" data-inner-id="lobipanel-data-attributes-7" data-index="6" style="display: block;"></div>
    </div>
    <div class="col-md-6 lobipanel-parent-sortable ui-sortable" data-lobipanel-child-inner-id="lobipanel-data-attributes-8 lobipanel-data-attributes-9 lobipanel-data-attributes-10 lobipanel-data-attributes-11 lobipanel-data-attributes-12">
        <div class="panel panel-default lobipanel lobipanel-sortable" data-inner-id="lobipanel-data-attributes-8" data-index="0" style="display: block;"></div>
        <div class="panel panel-default lobipanel lobipanel-sortable" data-inner-id="lobipanel-data-attributes-9" data-index="1" style="display: block;"></div>
        <div class="panel panel-default lobipanel lobipanel-sortable" data-inner-id="lobipanel-data-attributes-10" data-index="3" style="display: block;"></div>
        <div class="panel panel-default lobipanel lobipanel-sortable" data-inner-id="lobipanel-data-attributes-11" data-index="NaN" style="display: block;"></div>
        <div class="panel panel-default lobipanel lobipanel-sortable" data-inner-id="lobipanel-data-attributes-11" style="display: block;" data-index="5"></div>
        <div class="panel panel-default lobipanel lobipanel-sortable" data-inner-id="lobipanel-data-attributes-12" data-index="6" style="display: block;"></div>
    </div>
</div>

As you can see, i have a little NaN action going on. But this doesn't seem to affect anything. My problem is that i cant seem to save the position of panels that are moved from the left to the right (or the other way around). It does save the top to bottom arrangement. If i look at the html using firebug i do see the id of the panel added to the child-inner-id element but after a refresh it just places it back in the col where it started in the first place.

Am i doing something wrong or is this some sort of bug?

metalmini commented 7 years ago

This issue is resolved if you take this file: https://github.com/securityatrisk/lobipanel/blob/dea95313b6e16d64f4595da4209f7465b7cee279/dist/js/lobipanel.js

thecodeholic commented 7 years ago

Can you please make a pull request? It helps me to compare code and merge easily.

Thank you

metalmini commented 7 years ago

This wasn't a commit that i did, just found a fork that worked... So can't really help you with that.

I wanted to add that this fork has a annoying side effect that it reloads the page every time you drag a panel... So this is far from perfect.