search

thecodeholic / lobipanel

jQuery plugin for bootstrap panels. It extends panels with several common and useful functions.
MIT License
168 stars 75 forks source link

Event 'onClose.lobiPanel' is not triggered #7

Closed LionelMeroni closed 8 years ago

LionelMeroni commented 8 years ago

Hello,

It seem that the 'onClose.lobiPanel' event is not triggered.

robang10 commented 8 years ago

I am seeing the same issue with the onClose and beforeClose events.

LionelMeroni commented 8 years ago

Hi robang,

The beforeClose events works well for me. There are an issue with the onClose event because the panel is removed from the DOM. So, any event could not be triggered after that.

2016-05-16 23:12 GMT+02:00 robang10 notifications@github.com:

I am seeing the same issue with the onClose and beforeClose events.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/arboshiki/lobipanel/issues/7#issuecomment-219549613

robang10 commented 8 years ago

Yes I can get beforeClose to work.

Thanks!

From: LionelMeroni [mailto:notifications@github.com] Sent: Tuesday, May 17, 2016 12:35 AM To: arboshiki/lobipanel lobipanel@noreply.github.com Cc: Robert Angus robert.angus@autodesk.com; Comment comment@noreply.github.com Subject: Re: [arboshiki/lobipanel] Event 'onClose.lobiPanel' is not triggered (#7)

Hi robang,

The beforeClose events works well for me. There are an issue with the onClose event because the panel is removed from the DOM. So, any event could not be triggered after that.

2016-05-16 23:12 GMT+02:00 robang10 notifications@github.com<mailto:notifications@github.com>:

I am seeing the same issue with the onClose and beforeClose events.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/arboshiki/lobipanel/issues/7#issuecomment-219549613

— You are receiving this because you commented. Reply to this email directly or view it on GitHubhttps://github.com/arboshiki/lobipanel/issues/7#issuecomment-219631480

thecodeholic commented 8 years ago

onClose event is now triggered when animation is finished, but before panel is actually removed from DOM.