search

thecodejack / svelte-file-dropzone

Svelte component for fileupload
https://svelte-file-dropzone.netlify.app/
257 stars 45 forks source link

Svelte 5 support #166

Open madeleineostoja opened 2 months ago

madeleineostoja commented 2 months ago

Any plans to more fully support Svelte 5 now that's in release candidate?

The most notable change to bring svelte-file-dropzone in line with deprecations etc would just be to replace events (on:drag etc) with callbacks (ondrag etc).

I've also noticed that many svelte-file-dropzone props aren't properly reactive when I use it in a Svelte 5 (runes mode) environment. I haven't dug too far into it yet, but my first guess from a quick skim of the codebase is how events are composed.

arackaf commented 2 months ago

For sure - once it's stable we'll upgrade to Svelte 5 and bump a major version

harryqt commented 3 weeks ago

Svelte 5 is now stable.

ronny-rentner commented 2 weeks ago

This package is dead. Pull requests from years ago not taken care of...

arackaf commented 2 weeks ago

Not dead, but also not a ton of maintainers. I do merge pr's when they come up. I don't see any in the list of open ones that seem important, but if you think otherwise drop a link to which one and I'll take a look

ronny-rentner commented 1 week ago

Sorry if my previous comment sounded rude. That was not my intention. I just think either merge or close the PRs. It's not a good sign for potential future contributors if pull requests are laying around for more than a year.