Checkpointed data should not be put in agent's metadata workdir by default.

thecodeteam / mesos-module-dvdi

Mesos Docker Volume Driver Isolator module

Apache License 2.0

77 stars 16 forks source link

Checkpointed data should not be put in agent's metadata workdir by default. #94

Closed jieyu closed 8 years ago

jieyu commented 8 years ago

We should avoid that since that directory is owned by the Mesos agent. Mesos does not expect an isolator to put checkpointed data there. We should put it under /var/run/mesos/isolators/.

The directory in which the checkpointed data is put should be cleaned up on reboot. Otherwise, the isolator will try to recovery the checkpointed data after the reboot, thinking that mounts are still there. Therefore, putting checkpointed data under /var/run is recommended as it'll get cleaned up on reboot.

cantbewong commented 8 years ago

OK, this change makes sense and is feasible for next release

dvonthenen commented 8 years ago

Currently the checkpoint info is stored at: /tmp/mesos/meta/dvdimounts.pb

We will be moving to: /var/run/mesos/isolators/mesos-module-dvdi/dvdimounts.pb

Unless anyone has any objections.

dvonthenen commented 8 years ago

PR https://github.com/emccode/mesos-module-dvdi/pull/102 pending

dvonthenen commented 8 years ago

Has been merged. If there any issues, please let us know.