incorrect path to dvdcli on CoreOS

thecodeteam / mesos-module-dvdi

Mesos Docker Volume Driver Isolator module

Apache License 2.0

77 stars 16 forks source link

incorrect path to dvdcli on CoreOS #99

Closed mitel closed 8 years ago

mitel commented 8 years ago

Hello, the library will not work on CoreOS (eg: DC/OS) due to the following:

isolator/isolator/docker_volume_driver_isolator.hpp: static constexpr char DVDCLI_MOUNT_CMD[] = "/usr/bin/dvdcli mount"; static constexpr char DVDCLI_UNMOUNT_CMD[] = "/usr/bin/dvdcli unmount";

whereas dvdcli will install in /opt/bin on CoreOS: if [ -n "$IS_COREOS" ]; then BIN_DIR=/opt/bin BIN_FILE=$BIN_DIR/$BIN_NAME

dvonthenen commented 8 years ago

There is a PR https://github.com/emccode/mesos-module-dvdi/pull/100 ending that should help address this in a generic fashion

dvonthenen commented 8 years ago

The PR mentioned above has been merged. We can now specify which DVDCLI to use by fully qualified path per task. If this doesn't meet you requirements, we can revisit the issue.