search

thecodewarrior / Hooked

Adds terraria style hooks to minecraft
BSD 2-Clause "Simplified" License
12 stars 12 forks source link

Right clicking on a player in Multiplayer crashes your client #10

Closed Mario90900 closed 6 years ago

Mario90900 commented 6 years ago

I have just put together a large modpack that includes Hooked, so starting off it might be cross-mod issues that cause it. But currently in the pack, if you rightclick on another player it ends up crashing you with the crashlog talking about Hooked trying to get a capability marked as non-null, which is null. I have two crashlogs from two friends who had this happen:

https://pastebin.com/zrTHuZxf https://pastebin.com/wBNJQqdf

I would not be surprised in the least if it was another mod that was causing this, but I can't be sure which mod it is from the changelog. The only other one that shows up seems to be Better With Mods, so if it helps for me to disable that easy breeding thing and try it again, I can easily do so.

thecodewarrior commented 6 years ago

Update BetterWithMods, they weren't registering a capability properly in earlier versions.

Mario90900 commented 6 years ago

Oh alright, thanks for the quick response. I didn't notice BetterWithMods updated so recently, ill get on that right now.

Mario90900 commented 6 years ago

Even after updating the server to the newest version of Better With Mods, it still appears that right clicking on another player crashes you. Is there anything you can do on your end to work around this issue, or is it all on them?

thecodewarrior commented 6 years ago

I could fix it on my end, but they’re violating the API and my mod by accident is kind of a canary in the coal mine. This could cause all sorts of problems, many more subtle and difficult to debug, but since kotlin enforces nullability my mod crashes when that is violated. Yes it could be fixed, but shouldn’t, and yes, it’s all on them.