thecodewarrior / Hooked

Adds terraria style hooks to minecraft
BSD 2-Clause "Simplified" License
12 stars 12 forks source link

[Code Smell and Compile Time Warning] Ensure variables aren't null when passing to Java Methods #34

Closed JamesYeoman closed 4 years ago

JamesYeoman commented 4 years ago

As you can see from the following image, there are several warnings, some of which I'm cleaning up currently, and when my PR goes up, I'll link it to this issue. However, there are several nullability warnings that I'm not experienced and equipped enough to resolve... image

JamesYeoman commented 4 years ago

36

JamesYeoman commented 4 years ago

It turns out, according to thecodewarrior, that this isn't even a problem because forge has a global @ParametersAreNonnullByDefault, so it's safe to just suppress