chore: add execution right to ffi

thecodingmachine / docker-images-php

A set of PHP Docker images

MIT License

768 stars 137 forks source link

chore: add execution right to ffi #346

Closed qkdreyer closed 1 year ago

qkdreyer commented 1 year ago

Summary

This PR fixes/implements :

[x] Bug
[ ] Feature
[ ] Breaking changes

Checklist

[x] I followed the guidelines in CONTRIBUTING guide
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code

qkdreyer commented 1 year ago

@mistraloz sadly unit tests didn't check that 😞

qkdreyer commented 1 year ago

Dockerfile

ARG PHP_EXTENSIONS="ffi"
FROM thecodingmachine/php:8.1-v4-slim-fpm

qkdreyer commented 1 year ago

bump @mistraloz

mistraloz commented 1 year ago

Hello @qkdreyer sorry i forgot. Auto test seem broken. I relaunch failed to be sure. If it's work, i will merge your PR the 2nd january (because of usual hollydays at end of year, i prefer to dont commit any new feature during this period).

mistraloz commented 1 year ago

it's merged :)