search

thecodingmachine / docker-images-php

A set of PHP Docker images
MIT License
792 stars 139 forks source link

feat: use ubuntu lts (jammy 22.04) #347

Closed qkdreyer closed 1 year ago

qkdreyer commented 1 year ago

Summary

This PR fixes/implements :

Checklist

qkdreyer commented 1 year ago

bump @mistraloz

mistraloz commented 1 year ago

Same as others PR =) (to tell you all, i was sick on december : to much mail during my own outage xD). I'm very appreciate this PR, but i will not merge it on v4 because of changing the base release is a breaking change. We need to find a way to allow that.

We are working onto V5. Maybe i can find some time to rearrange V5 branch in january and allow your change on it. It's urgent for you ?

qkdreyer commented 1 year ago

Hey :) yeah sure let's merge this into a v5 branch. not that urgent but highly appreciated!

mistraloz commented 1 year ago

Did you saw that in CI testing? #60 57.41 ## Your distribution, identified as "jammy", is not currently supported, please contact NodeSource at https://github.com/nodesource/distributions/issues if you think this is incorrect or would like your distribution to be considered for support

Ok i just saw your last commit. You removed old node version ? (it's acceptable for v5)

qkdreyer commented 1 year ago

yeah, sadly jammy is not compatible with node 10/12

qkdreyer commented 1 year ago

I can't create the v5 branch btw and change this PR base branch

qkdreyer commented 1 year ago

I've rebased that branch on v4, you can review it and create the v5 branch @mistraloz

qkdreyer commented 1 year ago

ping @mistraloz

qkdreyer commented 1 year ago

any news?

qkdreyer commented 1 year ago

ping @mistraloz

mistraloz commented 1 year ago

Hello and sorry. I missed of time. I explained here the work for v5 #359 and i will starting it. I will try to integrate your work firstly (as alpha version).

qkdreyer commented 1 year ago

any news? 👀

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please update it if any action still required.

stale[bot] commented 1 year ago

This issue has been automatically closed because it has not had recent activity. Please, reopen if you need.

qkdreyer commented 1 year ago

Any news @mistraloz ?