Add PHP 8.2 support, fix testing

thecodingmachine / docker-images-php

A set of PHP Docker images

MIT License

768 stars 137 forks source link

Add PHP 8.2 support, fix testing #350

Closed todeveni closed 1 year ago

todeveni commented 1 year ago

Summary

Add PHP 8.2 support by mainly copying/replacing 8.1 as 8.2. Closes #348

This PR fixes/implements :

[x] Bug
[x] Feature
[ ] Breaking changes

Explain the motivation for making this change. What existing problem does the pull request solve?

Adds PHP 8.2 support and fixes building / testing locally.

Test plan (required)

test-quick and test-8.2 runs without errors after fixing uname -p call in Makefile.

Checklist

[x] I followed the guidelines in CONTRIBUTING guide
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code

laoneo commented 1 year ago

Would love to see PHP 8.2 support in this project as the stable version is out already?

mistraloz commented 1 year ago

thx for your MR, all seem good bug it's seem let's one error :

activated modules for one php version should be a symbolic link to core/.

May you fix that please ? (per example cd extensions && rm -rf 8.2/amqp && cd 8.2 && ln -s ../core/amqp .) For sure, if you changed something in extensions/8.2/*/install.sh , you may need to adjust extensions/core/*/install.sh

In any case, i will wait 2nd january to merge it (during end of year hollidays, it's never a good idea) but again, thank a lot for this work, very helpful.

PS: Take care, if you commit this whange with phpstorm, it's will switch your symlink to directory (i don't know why, but it work like that : you should commit with command line to be sure)

manuelkiessling commented 1 year ago

Hey @mistraloz, are you planning to merge this week?

mistraloz commented 1 year ago

It's merged :+1: Many thx for that

manuelkiessling commented 1 year ago

@mistraloz Thank you so much, and thank you for a beautiful and important project!