chore: install mongodb from PECL

guoard commented 10 months ago

To access the latest versions of the mongodb extension, we can install it from PECL since it is available there.

mistraloz commented 9 months ago

Thx for the PR. I'm not sure to merge it because of the impact for the build time on ARM. I running the test and i will see.

mistraloz commented 9 months ago

As expected it's longer with PECL :

On the current main branch : https://github.com/thecodingmachine/docker-images-php/actions/runs/6062260776/job/16448296704
Same task with the change for mongodb : https://github.com/thecodingmachine/docker-images-php/actions/runs/5910217885/job/16790268455?pr=367

It's not terminated yet but original one required 26min to build, the new one is not finished after 1 hour. For amd one, it's about the same 7min without PECL, 8min with.

It's a crazy amount of resources with 36 tests jobs (18 in arm) and 18 publish jobs (arm and amd one in one job). So i will not merge it but :

In v5 we will use https://github.com/mlocati/docker-php-extension-installer to do it : maybe it's managed better ?
In v5 we may not prebuild all extensions (dev will be encourraged to build their own from the slim one) : the main blocker is because github do not offer real arm instance (it's working with an emulator), in real arm machine the build time it's not so long.

So I'm closing this PR but you can open an issue (feature request) to speaking about that for v5

PS: Maybe another option is to use PECL for amd and apt for arm. I don't like this solution because the same tag will not provide the same versions... but it's acceptable as hotfix. So i'll reopen this PR if it's match for you.

thecodingmachine / docker-images-php

chore: install mongodb from PECL #367