Install Node using the new method to avoid deprecation message delay

dylanbr commented 1 year ago

Summary

NodeSource has deprecated the use of the installation script. It now results in a 60s timeout when building an image with Node included.

The new repo only has v16 and above, so the change only uses the new method for v16 and above. This means that the delay may still occur for v14 and below.

This PR fixes/implements :

[x] Bug
[ ] Feature
[ ] Breaking changes

Explain the motivation for making this change. What existing problem does the pull request solve?

Prevents a 60s wait when installing Node during builds.

Test plan (required)

Build the images for each Node version, and run node --version to check it is installed.

Checklist

[x] I followed the guidelines in CONTRIBUTING guide
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code

mistraloz commented 1 year ago

Thx, i was plan to fix it today... but you already did the job :+1: But the generation of blueprint should be executed and joigned with the commit. May you execute make blueprint please ?

Orbit tool is required for that, but very easy to install https://github.com/gulien/orbit#install

mistraloz commented 1 year ago

I did it in #371 i will merge the other one when will be ok

dylanbr commented 1 year ago

Thanks for assisting in getting this complete!

thecodingmachine / docker-images-php

Install Node using the new method to avoid deprecation message delay #370