thecodingmachine / docker-images-php

A set of PHP Docker images
MIT License
768 stars 137 forks source link

Add PHP 8.3 images #375

Closed iquito closed 6 months ago

iquito commented 7 months ago

PHP 8.3 officially released on the 23rd of November, and the packages for 8.3 used by these images are available, so it is probably quite straightforward to add 8.3 images. There seems to be some efforts into creating v5 images, but v4 PHP 8.3 images could be a good intermediate step.

todeveni commented 7 months ago

I've got a pull request ready for PHP 8.3, but waiting for #374 to merge first and non-alpha release for Xdebug. Don't know how healthy this project is though.

offskip-dave commented 6 months ago

@mistraloz @todeveni Is there any ETA for this?

kexxt commented 6 months ago

Xdebug supports PHP 8.3 as of the 30th https://xdebug.org/announcements/2023-11-30

todeveni commented 6 months ago

Xdebug supports PHP 8.3 as of the 30th

We (our company) are moving to another docker image, since this project seems dead and we need Node 20 support sooner than later. So don't expect PHP 8.3 PR from me either :)

kexxt commented 6 months ago

@todeveni I am in the same boat with my company, what are you looking at for a replacement? I'm trying to decide between doing it all in-house or finding a similar enough project...

todeveni commented 6 months ago

@todeveni I am in the same boat with my company, what are you looking at for a replacement? I'm trying to decide between doing it all in-house or finding a similar enough project...

Since we only need php82-node20-cli container for CI/CD pipelines, we're going with custom docker image based on official PHP image and installing Node into that. I might put the image into public use, if/when I have time to bolt on Dependabot/Renovate + Github actions automation to keep the image semiautomatically up to date.

nguyenk commented 6 months ago

Hello Folks,

@todeveni we apologies for the silence last days / weeks.

You are right to say the project seems dead, even this hurts a bit to read such words :sweat:.

We are putting efforts on releasing a v5 https://github.com/thecodingmachine/docker-images-php/blob/v5/ROADMAP_v5.md and we are struggling to find enough time to work on the previous version lately.

Could you please let us a day or two in order to check if we can merge your PR (and maybe you'd be open to submit the one you mentioned for PHP 8.3 ? :smile: ).

More then accepting your PRs, would you be interested in joining our efforts and become a maintainer of this repository ?

dschotman commented 6 months ago

Great to see the pull request #376 by @guoard for PHP 8.3 images! Can't wait till they are built and available on the registry! Thanks all for the great work 👍🏻

nguyenk commented 6 months ago

@todeveni thank's to @guoard 's contribution, we now have PHP 8.3 and node 20. Thanks again guys, and sorry for the delay.

Cheers

iquito commented 6 months ago

@nguyenk When do the images update/land on the registry, or is there a problem there? So far they are not available yet.

nguyenk commented 6 months ago

@iquito some test job failed, maybe temporary. I relaunched ... will keep you posted

nguyenk commented 6 months ago

And... it's available !! https://hub.docker.com/r/thecodingmachine/php/tags?page=1&name=8.3

iquito commented 6 months ago

Just tried it, works perfectly now. Thanks!

nguyenk commented 6 months ago

super :tada:

offskip-dave commented 6 months ago

Just pulled it and everything works! Thanks!