thecodingmachine / graphqlite-bundle

A Symfony bundle for thecodingmachine/graphqlite.
34 stars 37 forks source link

SF 6 support #166

Closed nguyenk closed 1 year ago

aszenz commented 1 year ago

@nguyenk Any way i could help in moving this pr forward

nguyenk commented 1 year ago

Hello @aszenz, please check comment here https://github.com/thecodingmachine/graphqlite-bundle/issues/142#issuecomment-1476186593

I released the beta 6.0 but still no feedback. Did you test it? If it's working then I think we can merge it!

aszenz commented 1 year ago

I released the beta 6.0 but still no feedback. Did you test it? If it's working then I think we can merge it!

Thanks, that's great

I just upgraded the pkg in our app, we were already using symfony 6.2 using a forked pkg.

I had to change the minimum stability to dev for it to work This is what composer did:

  - Upgrading thecodingmachine/graphqlite (v5.0.3 => v6.0.0)
  - Upgrading thecodingmachine/graphqlite-bundle (v5.4.0 => 6.0.x-dev e567930)
  - Upgrading thecodingmachine/graphqlite-symfony-validator-bridge (dev-jerowork/upgrade-symfony-to-6 fb5515e => 6.0.x-dev 7b1ee6e)

Our ci pipeline succeeded and I tested few screens manually which use graphql, everything seems to work fine.

I guess we need to release a new version for both graphqlite-bundle and graphqlite-symfony-validator-bridge pkgs

I do see some deprecations on symfony 6 though for this pkg, I guess we could fix them after release as well.

aszenz commented 1 year ago

@nguyenk Created #174 to fix the deprecation's, we can merge it in this pr

nguyenk commented 1 year ago

@aszenz merged to master, thank you again for your help