search

thecodingmachine / graphqlite-bundle

A Symfony bundle for thecodingmachine/graphqlite.
34 stars 36 forks source link

Remove overblog/graphiql-bundle #206

Open fogrye opened 2 months ago

fogrye commented 2 months ago

This package struggles hard with migration to Symfony v7 plus version of graphiql it brings is old by default and we don't have any info in docs how to update that. I would copy approach of how ApiPlatform does this thing with using 1 route, twig and minified js with latest version of graphiql. I would deliver this with https://github.com/thecodingmachine/graphqlite-bundle/pull/203 because now, at least in my case, overblog/graphiql-bundle is main blocker of migration to Symfony v7.

aszenz commented 2 months ago

This package struggles hard with migration to Symfony v7 plus version of graphiql it brings is old by default and we don't have any info in docs how to update that. I would copy approach of how ApiPlatform does this thing with using 1 route, twig and minified js with latest version of graphiql. I would deliver this with #203 because now, at least in my case, overblog/graphiql-bundle is main blocker of migration to Symfony v7.

We could also just split/remove the graphiql route into it's own bundle since it's not really this bundle's job to provide a graphql editor, this bundle is about symfony integration

fogrye commented 2 months ago

@aszenz IMHO it's nice for newbie but I would not advocate it that much. Me personally don't have access to create repos under thecodingmachine but I think it would be nice to have separate repo as a suggestion if you actually need it. If we can somehow make a new repo it would be great.

SCIF commented 2 months ago

@fogrye ,

remove the graphiql route into it's own bundle since it's not really this bundle's job to provide a graphql editor

Totally «for» this statement. A nice tooling is not something bundle should be really worry about. Moreover, overblog's bundle is not prod-required package so having it as a dep is actually a bad idea.

fogrye commented 2 months ago

As this issue takes more attention recently I encourage anyone to make a PR for it. Unfortunately I have too much on myself so I won't be able to contribute to it in next couple of weeks.

homersimpsons commented 2 months ago

To share my opinion on this: I'm not against removing it, specifically if it blocks some upgrade. But I know this is a valuable tool for devlopment and having it integrated certainly improves the developer experience.

If we remove it, there should be an easy / documented way to have such tool, I know Postman or similar applications provides this so maybe we can just redirect the users to those tools.

goffyara commented 1 month ago

My opinion is that it's better to remove the dependency on the bundle. Anyone who needs it will be able to configure it themselves or use another documentation tool of their choice. Moreover, the native ability to override the endpoint to which the overblog bundle sends requests is currently blocked, and it's necessary to write a separate CompilerPass just for this.