Closed grynchuk closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.29%. Comparing base (
53f9d49
) to head (5364cde
). Report is 68 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@oojacoboo These fixes merged for the 7.x
version of graphqlite, but there's a major performance problem with 7.x
which is blocked update for 7.x
for the Symfony bundle - https://github.com/thecodingmachine/graphqlite-bundle/pull/203#issuecomment-2201182492
And issue in graphqlite - https://github.com/thecodingmachine/graphqlite/issues/691
Would you approve PR with the same changes, but for 6.x
branch of graphqlite (and tag an additional 6.x
release after merge)?
@andrew-demb maybe it's just a better idea to test the changes in class-finder
as per the comments in #691 and get that resolved, instead of just back patching, to prevent resolving the actual issue, assuming that you're even seeing any degraded performance.
I have issue with getting wrong prefetch data while query in batch mode. In short, first query prefetch specific data and set it to prefetch buffer, second query use previous query prefetch buffer instead of using its own and get incomplete data set. I have to note that this issue is relates to prefetching of nested data, see test for mo details.
Request:
Response Actual:
Expected: