search

thecodingmachine / graphqlite

Use PHP Attributes/Annotations to declare your GraphQL API
https://graphqlite.thecodingmachine.io
MIT License
554 stars 95 forks source link

Add a comment mentioning that FilesystemCache can be used when APCu isn't available #662

Closed shish closed 4 months ago

shish commented 4 months ago

Add a comment mentioning that FilesystemCache can be used when APCu isn't available

APCu isn't enabled by default, which makes the example crash, and there are no hints as to what the user is supposed to do about it

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.29%. Comparing base (53f9d49) to head (87d2e68). Report is 69 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #662 +/- ## ============================================ - Coverage 95.72% 95.29% -0.44% - Complexity 1773 1818 +45 ============================================ Files 154 171 +17 Lines 4586 4841 +255 ============================================ + Hits 4390 4613 +223 - Misses 196 228 +32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

oojacoboo commented 4 months ago

I think this one could be updated to be a code comment. But APCu should be encouraged for performance purposes. People shouldn't assume that the filesystem is suitable for cache. It really shouldn't be used.

So, it should stay as APCu with a comment that the Filesystem can be used for testing, but isn't encouraged for performance reasons!