search

thecodingmachine / graphqlite

Use PHP Attributes/Annotations to declare your GraphQL API
https://graphqlite.thecodingmachine.io
MIT License
554 stars 95 forks source link

Fix promoted default values #672

Closed oprypkhantc closed 4 months ago

oprypkhantc commented 4 months ago

Hey

Currently constructor promoted properties' default values are ignored, because ReflectionClass::getDefaultProperties() does not return default values from promoted props.

This fixes it, so the behaviour matches regular properties.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.28%. Comparing base (53f9d49) to head (e8f2c4a). Report is 76 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #672 +/- ## ============================================ - Coverage 95.72% 95.28% -0.45% - Complexity 1773 1828 +55 ============================================ Files 154 171 +17 Lines 4586 4854 +268 ============================================ + Hits 4390 4625 +235 - Misses 196 229 +33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.