search

thecodingmachine / graphqlite

Use PHP Attributes/Annotations to declare your GraphQL API
https://graphqlite.thecodingmachine.io
MIT License
554 stars 95 forks source link

patch: drop DoctrineAnnotations #677

Closed fogrye closed 3 months ago

fogrye commented 3 months ago

BC: AnnotationReader constructor changed and it's methods stops triggering exceptions

TestControllerWithInvalidParameterAnnotation deleted as for is ignored when HideParameter used as parameter attribute

Also attribute exceptions and classes polished

Fixes: #675

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.31%. Comparing base (53f9d49) to head (ea1570b). Report is 81 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #677 +/- ## ============================================ - Coverage 95.72% 95.31% -0.41% - Complexity 1773 1809 +36 ============================================ Files 154 171 +17 Lines 4586 4783 +197 ============================================ + Hits 4390 4559 +169 - Misses 196 224 +28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fogrye commented 3 months ago

@oojacoboo I marked this PR as draft because I though it would be nice to fix documentation with it (and remove php7 examples as we do not support it). Or I can have make that in separate PR. What is better for you?

oojacoboo commented 3 months ago

@oojacoboo I marked this PR as draft because I though it would be nice to fix documentation with it (and remove php7 examples as we do not support it). Or I can have make that in separate PR. What is better for you?

Agreed. Let's update the docs in this PR.