search

thecodingmachine / graphqlite

Use PHP Attributes/Annotations to declare your GraphQL API
https://graphqlite.thecodingmachine.io
MIT License
553 stars 95 forks source link

Update cache-utils library #693

Closed sudevva closed 15 hours ago

sudevva commented 1 week ago

Hey, guys. I'm pretty sure I'm writing to wrong repository, but there is the issue with caching library, that no one care in that repo. I'm just trying to speed up the process)

https://github.com/thecodingmachine/cache-utils/pull/8

Thank you!

oojacoboo commented 1 week ago

So, I don’t have any write access over there, only this repository. We’ve had similar issues on other repos from thecodingmachine that were added like this. It’s really just best we replace them with something that’s actually managed. It looks like this is the last dependency.

A PR to replace this lib with another cache lib or by using a PSR compatible cache interface that’s set through the config, would be ideal.

I don’t know how much value this file modification check has for caching TTL. I haven’t looked into that lib in depth or how it’s implemented. But there was some langauage around Doctrine annotations, which are now deprecated. I don’t think we need to make any considerations around those going forward.

xyng commented 2 days ago

@oojacoboo thank you for outlining the required change. I have prepared a (simple) pr that removes the packages and its ttl functionality while providing a way to support a fork of that package.