WINDOWS: altering path multiple times creating a too loong string

thecodingmachine / nodejs-installer

An installer package that let's you install NodeJS and NPM as a Composer dependency.

107 stars 28 forks source link

WINDOWS: altering path multiple times creating a too loong string #33

Closed delmicio closed 6 years ago

delmicio commented 6 years ago

Hi, the npm.bat file appends PATH to PATH every time the bat is called, this should only be done the first time.

moufmouf commented 6 years ago

Hey @delmicio ,

When npm.bat calls "set PATH", the PATH is only modified for the current process, not the whole Windows environment. So unless npm is calling recursively itself (it seems a bit weird to me), this should not be an issue at all.

Are you facing a bug due to the length of the PATH environment variable? If yes, can you describe a way to reproduce the issue?

delmicio commented 6 years ago

Sorry, can not reproduce. :(