Open Aerendir opened 2 years ago
@Aerendir This would be fixed by https://github.com/thecodingmachine/safe/pull/372, correct?
@dbrekelmans yes, it will, but will break compatibility with older versions. The code I proposed maintains backward compatibility.
I just saw you released the version 2.2.3
, so you merged the PR #372 in a patch release.
This change, however, is potentially backward breaking change, so it should have been merged in a major release if you follow the semver.
Using the code I suggested, instead, it would not break backward compatibility and can be released also in a patch release. My 2 cents.
Sorry I was in holidays for the last 2 weeks, i didn't see your thread.
We definitly don't want to break semVer. If you are confident about your code, i am in favor of merging it over #372 and quickly publishing a new tag to cover our mistake. Or we delete the current tag and create a major release. (but a major release just to fix rector is weird)
@dbrekelmans what do you think?
Agreed. I would be in favor of doing a new patch release after this is merged.
I will try to do it tomorrow
Thanks a lot for the suggested patch.
Real question here:
Do we want to ensure SEMVER for Rector? I mean, it is not run at runtime, and I doubt someone is running this in a CI/CD too. Shouldn't we exclude it from semver support? (I'm saying this because if at some point, we cannot do rector-migrate file that supports all rector versions, I'd rather drop support for older Rector releases than prevent Safe users to use a newer Rector release.
The new configuration is this:
To support older versions: