search

thecodingmachine / safe

All PHP functions, rewritten to throw exceptions instead of returning false
MIT License
2.35k stars 140 forks source link

specify Safe\createFromMutable return changing type for php8.2 #406

Closed helyakin closed 1 year ago

helyakin commented 1 year ago

When migrating to PHP8.2 I have the following issue with Safe\createFromMutable

Capture d’écran 2022-12-28 à 15 07 43

Adding #[\ReturnTypeWillChange] fixes it.

I don't know if it's the best solution, but it's my proposition.

Feel free to tell me what should be done if this not the appropriate solution

helyakin commented 1 year ago

I've opened this PR one month ago, would it be possible to have a review ? That would be very nice of you =)

akondas commented 1 year ago

Can we merge and release this?

Kharhamel commented 1 year ago

Sorry I stopped checking on the project for a will. Before I deploy this,, I need to fix a bunch of things, mostly related to all the functions that needs to be deprecated. I will have some holidays this week, hope I can get this project back in shape.

Kharhamel commented 1 year ago

this is deployed in v2.5.0