search

thecodingmachine / safe

All PHP functions, rewritten to throw exceptions instead of returning false
MIT License
2.37k stars 153 forks source link

Consider improving codegen #434

Open simPod opened 1 year ago

simPod commented 1 year ago

It's very well explained in this comment: https://github.com/phpstan/phpstan-src/pull/2693#issuecomment-1784026934

TLDR the functionMap is not always correct. Safe should consider multiple resources for codegeneration.