search

thecodingmachine / safe

All PHP functions, rewritten to throw exceptions instead of returning false
MIT License
2.37k stars 149 forks source link

Are you looking for maintainers here? #452

Closed OskarStark closed 4 days ago

OskarStark commented 2 months ago

It looks like there is not much activity here, so I would offer my help to maintain this repository.

Cheers, Oskar

cc @mvhirsch @igst @silasjoisten @localheinz @staabm

silasjoisten commented 2 months ago

I would too.

shish commented 1 week ago

FWIW I have a maintained fork (with nearly all of the PR's here merged, flagged as a drop-in replacement so you only need to update dependencies for the top-level composer.json) at https://github.com/shish/safe

moufmouf commented 5 days ago

Hey all!

Sorry, @Kharhamel and I have had some hectic schedule. I'm working full time on WorkAdventure and obviously don't have enough time to maintain the project appropriately.

So, YES! we are looking for maintainers.

I'll do my best to put Safe in a correct state for PHP 8.4, but Safe definitely needs some love. @shish I'll probably backport the changes in your fork. Do you want to be added as a maintainer? (@OskarStark, @silasjoisten I would be happy to add you too, shall I do that?)

OskarStark commented 5 days ago

Yes please add both of us (Silas and I are working together)

moufmouf commented 5 days ago

@OskarStark @silasjoisten Done! What would be the good way of doing things starting from here? Backporting all @shish changes and then starting merging submitted PRs that are not already part of @shish work?

silasjoisten commented 5 days ago

Sounds good to me!

shish commented 4 days ago

Yeah I'm happy to be added as a maintainer and avoid fragmentation :)

OskarStark commented 4 days ago

@staabm, what about you?

staabm commented 4 days ago

sure, why not.

(Please also add us to the phpstan extension repo)

moufmouf commented 4 days ago

Cool! @shish @staabm @OskarStark @silasjoisten You have all be added to this repo and the PHPStan extension.

Super happy to have you guys as maintainers. I should have done that way before!

I think the best thing to do for me is to step aside and let you guys merge your respective PRs and tag releases accordingly. You are all experienced maintainers so I won't get in the way! :heart:

OskarStark commented 4 days ago

Thanks for the trust and being open 🖖 community will thank you 🙏

danepowell commented 4 days ago

When you backport the changes, I'd appreciate if you please don't drop support for PHP 8.1 until it's officially EOL next year 😄

https://github.com/thecodingmachine/safe/pull/441#issuecomment-2499226690